[Skiboot] [PATCH v3 08/10] console: use opal_con_ops API
andrew.donnellan at au1.ibm.com
Tue Jan 3 16:01:58 AEDT 2017
On 21/12/16 15:52, Oliver O'Halloran wrote:
> Adds a new structure that contains the implementations of the various
> OPAL console handlers. This is intended to replace the existing ad-hoc
> mechanism where the OPAL call handlers are overwritten in the OPAL
> console driver's init function.
> Currently this just moves the site where the OPAL call handlers are
> overwritten to inside of console.c, but it is intended to give us a
> mechanism for implementing features such as pointer validation for the
> OPAL console calls without having to manually update each driver.
> This also helps to clarify differences between the internal (skiboot)
> console and the external (OPAL) console.
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> v2 -> v3:
> Reworked patch to that the driver specific structures are
> introduced before using them.
This doesn't apply completely cleanly on master:
ajd at ajd:~/code/skiboot$ patch -p1 < .git/rebase-apply/patch
patching file core/console.c
Hunk #3 succeeded at 321 with fuzz 1.
Hunk #4 succeeded at 386 (offset -3 lines).
Hunk #5 succeeded at 401 (offset -3 lines).
Hunk #6 succeeded at 416 (offset -3 lines).
patching file core/init.c
patching file core/platform.c
Hunk #1 succeeded at 114 (offset 3 lines).
patching file hw/fsp/fsp-console.c
patching file hw/lpc-uart.c
patching file include/console.h
patching file platforms/astbmc/common.c
patching file platforms/qemu/qemu.c
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com IBM Australia Limited
More information about the Skiboot