[Skiboot] [PATCH V3 2/2] platforms/zz: Initialize PRD in skiboot

Ananth N Mavinakayanahalli ananth at linux.vnet.ibm.com
Fri Feb 24 21:30:27 AEDT 2017


... since PRD runs in host userspace on P9 FSP based systems.

Signed-off-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
---
 hw/prd.c               |   10 +++-------
 platforms/ibm-fsp/zz.c |    3 +++
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/hw/prd.c b/hw/prd.c
index a5c8cc3..c8f2155 100644
--- a/hw/prd.c
+++ b/hw/prd.c
@@ -390,13 +390,9 @@ void prd_init(void)
 	}
 	unlock(&ipoll_lock);
 
-	if (fsp_present()) {
-		/* todo: FSP implementation */
-		queue_prd_msg = queue_prd_msg_nop;
-	} else {
-		queue_prd_msg = queue_prd_msg_hbrt;
-		opal_register(OPAL_PRD_MSG, opal_prd_msg, 1);
-	}
+	/* All P9 machines, even the FSP based ones run PRD in host userspace */
+	queue_prd_msg = queue_prd_msg_hbrt;
+	opal_register(OPAL_PRD_MSG, opal_prd_msg, 1);
 
 	prd_node = dt_new(opal_node, "diagnostics");
 	dt_add_property_strings(prd_node, "compatible", "ibm,opal-prd");
diff --git a/platforms/ibm-fsp/zz.c b/platforms/ibm-fsp/zz.c
index 89d87b4..5c0b3b1 100644
--- a/platforms/ibm-fsp/zz.c
+++ b/platforms/ibm-fsp/zz.c
@@ -29,6 +29,9 @@
 
 static bool zz_probe(void)
 {
+	/* PRD runs in host userspace in P9 */
+	prd_init();
+
 	/* FIXME: make this neater when the dust settles */
 	if (dt_node_is_compatible(dt_root, "ibm,zz-1s2u") ||
 	    dt_node_is_compatible(dt_root, "ibm,zz-1s4u") ||



More information about the Skiboot mailing list