[Skiboot] [PATCH V2] platforms/zz: Initialize PRD in skiboot

Mahesh Jagannath Salgaonkar mahesh at linux.vnet.ibm.com
Fri Feb 24 15:39:58 AEDT 2017


On 02/24/2017 06:19 AM, Ananth N Mavinakayanahalli wrote:
> ... since PRD runs in host userspace for FSP based P9 systems.
> 
> Signed-off-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>

Reviewed-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>

> ---
>  hw/prd.c               |   16 +++++++++-------
>  platforms/ibm-fsp/zz.c |    3 +++
>  2 files changed, 12 insertions(+), 7 deletions(-)
> 
> diff --git a/hw/prd.c b/hw/prd.c
> index a44faa9..d63c03f 100644
> --- a/hw/prd.c
> +++ b/hw/prd.c
> @@ -361,13 +361,15 @@ void prd_init(void)
>  	}
>  	unlock(&ipoll_lock);
>  
> -	if (fsp_present()) {
> -		/* todo: FSP implementation */
> -		queue_prd_msg = queue_prd_msg_nop;
> -	} else {
> -		queue_prd_msg = queue_prd_msg_hbrt;
> -		opal_register(OPAL_PRD_MSG, opal_prd_msg, 1);
> -	}
> +	/*
> +	 * P9 FSP based systems work similar to the OpenPOWER
> +	 * ones in that the PRD runs in host userspace. On such
> +	 * systems, prd_init() gets called from the platform
> +	 * probe callback and the setup for them is similar
> +	 * to the OpenPOWER systems.
> +	 */
> +	queue_prd_msg = queue_prd_msg_hbrt;
> +	opal_register(OPAL_PRD_MSG, opal_prd_msg, 1);
>  
>  	prd_node = dt_new(opal_node, "diagnostics");
>  	dt_add_property_strings(prd_node, "compatible", "ibm,opal-prd");
> diff --git a/platforms/ibm-fsp/zz.c b/platforms/ibm-fsp/zz.c
> index 89d87b4..4d50799 100644
> --- a/platforms/ibm-fsp/zz.c
> +++ b/platforms/ibm-fsp/zz.c
> @@ -29,6 +29,9 @@
>  
>  static bool zz_probe(void)
>  {
> +	/* PRD runs in host userspace on P9 FSP platforms */
> +	prd_init();
> +
>  	/* FIXME: make this neater when the dust settles */
>  	if (dt_node_is_compatible(dt_root, "ibm,zz-1s2u") ||
>  	    dt_node_is_compatible(dt_root, "ibm,zz-1s4u") ||
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
> 



More information about the Skiboot mailing list