[Skiboot] [PATCH 2/2] pci/quirk: Populate device tree for AST2400 VGA

[Joel Stanley]

On Thu, Feb 23, 2017 at 4:09 PM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
> On Thu, 2017-02-23 at 16:36 +1100, Stewart Smith wrote:
>> > Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
>> > > > +       dt_add_property_cells(np, "ast,scu-revision-id", revision);
>> > > > +       dt_add_property_cells(np, "ast,mcr-configuration", mcr_configuration);
>> > > > +       dt_add_property_cells(np, "ast,mcr-scu-mpll", mcr_scu_mpll);
>> > > > +       dt_add_property_cells(np, "ast,mcr-scu-strap", mcr_scu_strap);
>> > +   dt_add_property(np, "ast,must-init-vga", NULL, 0);
>>
>> Anywhere these are/going to be documented?
>
> Don't you like magic ? :-)

More magic!

I'd like to see a document go in to Linux's
Documentation/devicetree/bindings as part of benh's kernel series.

Related to the patch: in reviewing the kernel side we changed the
vendor prefix to "aspeed" to match the rest of the kernel.

 https://patchwork.kernel.org/patch/9589255/

+ * If some properties are missing, use reasonable
+ * defaults for AST2400
+ */
+ if (of_property_read_u32(np, "aspeed,mcr-configuration",
+ &mcr_cfg))
+ mcr_cfg = 0x00000577;
+ if (of_property_read_u32(np, "aspeed,mcr-scu-mpll",
+ &mcr_scu_mpll))
+ mcr_scu_mpll = 0x000050C0;
+ if (of_property_read_u32(np, "aspeed,mcr-scu-strap",
+ &mcr_scu_strap))

Russell, can you re-spin with this spelling?

Cheers,

Joel