[Skiboot] [PATCH v2] core/console: refactor __flush_console()

Stewart Smith stewart at linux.vnet.ibm.com
Thu Feb 23 15:04:24 AEDT 2017

Oliver O'Halloran <oohall at gmail.com> writes:
> Simplifies the flushing logic so that we only call into
> con_driver->write() once. The existing implementation splits the
> function into a normal path and a separate path when the in memory
> console has wrapped. The logic is the same in both branches and
> __flush_console() has enough bizarre crap happening with it's
> not-a-lock-but-actually-a-lock flag variable.
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> Spelling-corrected-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> ---
>  core/console.c | 49 +++++++++++++++++++++++++------------------------
>  1 file changed, 25 insertions(+), 24 deletions(-)

So, I seem to be adequately convinced this is okay and merged it to
master as of c55f3f83789fdc865d7052beaab5ebedea55b042.

Now to wipe up the tears after looking at __flush_console() again.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list