[Skiboot] [PATCH] external/gard: Fix make dist target

Stewart Smith stewart at linux.vnet.ibm.com
Thu Feb 23 13:11:46 AEDT 2017


Cyril Bur <cyril.bur at au1.ibm.com> writes:
> Several problems:
> Firstly, it could never have worked, it was using the wrong variable.
>
> Secondly, if it was using GARD_VERSION it produced a broken tarball that
> still looked into the skiboot source for files despite them having been
> copied into the tarball.
>
> Lastly (and not really a make dist issue) the current way of symlinking
> make_version.sh was racey. Get around the issue by refering to it in its
> actual location (if we know it will be there) or by looking at .version
> if building from tarball.
>
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>

well... appears to produce something that builds, so merged to master as
of 8ab0caf26de9d9cc12223c4b945052b50508bf78

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list