[Skiboot] [PATCH]: Implementation of opalmsg command in crash-utility

Ankit Kumar ankit at linux.vnet.ibm.com
Sat Feb 18 00:24:17 AEDT 2017

Hi Stewart,

Thank you so much for taking time and reviewing.

On Thursday 16 February 2017 12:32 PM, Stewart Smith wrote:
> Ankit Kumar <ankit at linux.vnet.ibm.com> writes:
>> +/*
>> + * Definitions derived from OPAL. These need to track corresponding values in
>> + * https://github.com/open-power/skiboot/blob/master/include/mem-map.h
>> + */
>> +#define SKIBOOT_CONSOLE_DUMP_START	0x31000000
>> +#define SKIBOOT_CONSOLE_DUMP_SIZE	0x40000
> Where did you get this size from?
> INMEM_CON_LEN in skiboot is 0x100000

Sorry about that.
Will send a patch correcting this.


> Even if booting a kdump kernel, you're going to have a device tree with
> the appropriate nodes present to *programatically* find out where the
> console is. You should certainly do that.

Currently, INMEM_CON_START(console start address) and 
INMEM_CON_LEN(size) is not part of kernel symbol table.

In crash-utility , I didn't find a way to read device-tree node from 
collected vmcore file and Hence, I hard-coded these values.

I am looking on it. Will correct this, once I get the way to read 
device-tree entry in crash-utility from collected vmcore dump.


More information about the Skiboot mailing list