[Skiboot] [PATCH 1/8] platforms/astbmc: Support SMC's P8DNU

[Gavin Shan]

On Thu, Feb 16, 2017 at 06:43:48PM +1100, Stewart Smith wrote:
>Gavin Shan <gwshan at linux.vnet.ibm.com> writes:
>> +++ b/platforms/astbmc/p8dnu.c
>> @@ -0,0 +1,345 @@
>> +/* Copyright 2013-2014 IBM Corp.
>
>Should have to 2017. Likely also SuperMicro's copyright added?
>

Yeah, will update in next respin.

>> +DECLARE_PLATFORM(p8dnu) = {
>> +	.name			= "P8DNU",
>> +	.probe			= p8dnu_probe,
>> +	.init			= astbmc_init,
>> +	.pci_get_slot_info	= slot_table_get_slot_info,
>> +	.cec_power_down         = astbmc_ipmi_power_down,
>> +	.cec_reboot             = astbmc_ipmi_reboot,
>> +	.elog_commit		= ipmi_elog_commit,
>> +	.start_preload_resource	= flash_start_preload_resource,
>> +	.resource_loaded	= flash_resource_loaded,
>> +	.exit			= ipmi_wdt_final_reset,
>> +	.terminate		= ipmi_terminate,
>> +};-
>
>Should this also have:
>        .bmc                    = &astbmc_smc,
>
>?
>
>This is what p8dtu1u and p8dtu2u have in order to set the correct IPMI
>OEM codes. Without this, skiboot will send the incorrect IPMI codes to
>the BMC.
>

Yes, I think we need this. Otherwise the default OEM codes will be sent.
I'll update in next respin.

Thanks,
Gavin

>-- 
>Stewart Smith
>OPAL Architect, IBM.