[Skiboot] [PATCH v2]: Adds support in crash-utility to dump opal console buffer for PPC64

[Ankit Kumar]

Hi Vipin,


On Wednesday 15 February 2017 02:11 PM, Vipin K Parashar wrote:
> Hi Ankit,
>
>>   "  This command displays data specific to a machine type.\n",
>>   "    -m  Display the physical memory map (x86, x86_64 and ia64 
>> only).",
>>   "    -c  Display each cpu's cpuinfo structure (x86, x86_64 and ia64 
>> only).",
>> @@ -2298,6 +2298,7 @@ char *help_mach[] = {
>>   "        Display the hwrpb_struct, and each cpu's percpu_struct 
>> (alpha only).",
>>   "    -x  override default output format with hexadecimal format.",
>>   "    -d  override default output format with decimal format.",
>> +"    -o  Display opal console log in crash (ppc64 only).",
>
> At first glance, -o seems to signify octal here and an extension to 
> previous
> -x (hexadecimal) and -d (decimal) options. So would be good to choose
> something more intuitive apart from -o for opal logs ?
>
> Also any particular reason for choosing "mach" command for adding
> support for displaying OPAL logs. Currently crash utility has 'log' 
> command
> for dumping kernel logs, and how about adding a new command say 'fwlog'
> altogether for this ?


As this operation is specific to power and hence it is implemented under 
mach command.
Please see Dave's reply on [PATCH v1] for more details.

~Ankit

> A new command (may be ppc64 only for now) might be a good idea here,
> as it will enable us to add more options into it in future.
>
>
>