[Skiboot] [Crash-utility] [PATCH v2]: Adds support in crash-utility to dump opal console buffer for PPC64

Ankit Kumar ankit at linux.vnet.ibm.com
Wed Feb 15 02:31:21 AEDT 2017

Hi Dave,

On Tuesday 14 February 2017 08:43 PM, Dave Anderson wrote:
> ----- Original Message -----
>> This patch adds support in crash-utility to dump opal console buffer for PPC64
>> by adding -o option in mach command. Currently start address and size of opal
>> console log buffer is hard-coded.
>> As this option is specific to POWER, it is coded as such.
> Hello Ankit,
> OK, this looks good.  I went ahead and addressed these compiler warnings:
> $ make warn
>   CRASH: 7.1.8rc19
>     GDB: 7.6
> cc -c -g -DPPC64  -DGDB_7_6  build_data.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security
> cc -c -g -DPPC64  -DGDB_7_6  ppc64.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security
> ppc64.c:2747:1: warning: no previous prototype for ‘opalmsg’ [-Wmissing-prototypes]
>   opalmsg(void)
>   ^
> ppc64.c: In function ‘opalmsg’:
> ppc64.c:2815:3: warning: implicit declaration of function ‘isprint’ [-Wimplicit-function-declaration]
>     if (isprint(mem.u8)) {
>     ^
> ppc64.c:2764:8: warning: unused variable ‘addrtype’ [-Wunused-variable]
>    char *addrtype;
>          ^
> ppc64.c:2761:17: warning: unused variable ‘sz’ [-Wunused-variable]
>    size_t typesz, sz;
>                   ^
> I also fixed up the help page a bit, and replaced the fprintf(fp) error
> messages in ppc64_cmd_mach() with error(FATAL) calls.  The borrowing of
> the memloc structure from the generic display_memory() function is
> overkill, but I left it alone in case you ever want extend the function
> to read non-ASCII data (?).

"make" didn't complain for above warning. (I could have also checked 
with make warn).
Next time onwards, will take care of this.

> Queued for crash-7.1.8:
>    https://github.com/crash-utility/crash/commit/1a4af84dbda299bcf0a54b1e76eb963f3bbff98b

Thank you.


More information about the Skiboot mailing list