[Skiboot] [Crash-utility] [PATCH]: Implementation of opalmsg command in crash-utility

[Ankit Kumar]

Hi Dave,


On Tuesday 07 February 2017 08:11 PM, Dave Anderson wrote:
>
> ----- Original Message -----
>> This patch creates 'opalmsg' command which can be used to dump opal console log
>> in crash. Currently it uses hard-coded start address and size of opal console log buffer.
>> As this command is specific to POWER, it is coded as such.
> Hi Ankit,
>
> There's no way I'm going to add such a subsystem- and machine-specific command to the standard
> set of generic commands.  The base command set is almost never extended, where, for example,
> the "ipcs" and "tree" commands were added in 2012, and are the only ones added since the
> crash utility was originally introduced.
>
> Here are a couple suggestions:
>
>   (1) Make it an extension module, which can be hosted on the extensions page here:
>
>         http://people.redhat.com/anderson/extensions.html
>
>   (2) Make it an option to the "mach" command, which does advertise several machine-specific
>       options:
>
>         crash> help mach
>
>         NAME
>           mach - machine specific data
>
>         SYNOPSIS
>           mach [-m | -c -[xd]]
>
>         DESCRIPTION
>           This command displays data specific to a machine type.
>
>             -m  Display the physical memory map (x86, x86_64 and ia64 only).
>             -c  Display each cpu's cpuinfo structure (x86, x86_64 and ia64 only).
>                 Display each cpu's x8664_pda structure (x86_64 only),
>                 Display the hwrpb_struct, and each cpu's percpu_struct (alpha only).
>             -x  override default output format with hexadecimal format.
>             -d  override default output format with decimal format.
>
>         EXAMPLES
>         ...
>
> Your choice, but at least "mach -o" or whatever would allow it to be contained
> in the crash binary.  Sound reasonable?
>
> Dave
>

Thank you so much for your quick reply and nice suggestion.
Will rework and send the patch soon.

~Ankit