[Skiboot] [PATCH] platform: Add witherspoon

Michael Neuling mikey at neuling.org
Sat Feb 11 09:42:08 AEDT 2017


On Fri, 2017-02-10 at 16:44 +1100, Oliver O'Halloran wrote:
> On Fri, Feb 10, 2017 at 2:44 PM, Michael Neuling <mikey at neuling.org> wrote:
> > +----------------------------------------------------------------------+
> > > ooooooooooooooooooooooooo=+++:++++::::~:::::::+==ooooooooooooooooooooo|
> > > oooooooooooooooooooooo+++++++++++++:+:~...:++++:+==ooooooooooooooooooo|
> > > oooooooooooooooooooo++++=++==+++::~~~~   .~~+++++++=oooooooooooooooooo|
> > > oooooooooooooooooo+:++====+++::~..~~~~... .~:++++++++=oooooooooooooooo|
> > > oooooooooooooooo=::++=+=++++:~~~:::::~~..  ~:++++++=++=ooooooooooooooo|
> > > ooooooooooooooo=::+++++:++:::::+++:::~.....:++:+++++=++=oooooooooooooo|
> > > oooooooooooooo+~::+:+:::::~::+++++++:~~:++::+++::++++===oooooooooooooo|
> > > ooooooooooooo=:~:::::~:::::++++=+=+:::++++++:+++::++++====oooooooooooo|
> > > ooooooooooooo:~::~::~~:::::++=+=++::+=++++++:++=:::++++===oooooooooooo|
> > > oooooooooooo:~~~~~~~~~~:::+:++=+:++++++=+=+++++++:::+=+====ooooooooooo|
> > > ooooooooooo+~~~~~~~~:~~:::++++::+=+++==+++++:::=+::::+=+===ooooooooooo|
> > > oooooooooo=~~~:~~~~~~.~~:::++::++++++++++++++:++++::::+++==ooooooooooo|
> > > oooooooooo:~.~~~~~.~..~~::::::+++++++++++++++:::++:::::=====oooooooooo|
> > > ooooooooo+~..~:~....~.~~~~~~~~:+++++++::~~~~~::::++::::+==+=oooooo====|
> > > oooooooo+~~.~:~~.~..~~::~...  .~::+:+::~.    ..~::::~::++=:+=o=o=====o|
> > > ooooooo=~~..~:~~~  ~::~.     .~~~:+++::~~:. .. .~:::~~~++=:+===oooooo=|
> > > o=o==o=::~.~:::~~  :::+:~~~~~:::+:+=++:::::~~~:+++::~..:+=::+=====o==o|
> > > =======~~.~:::::  .~:++++++:::++++++++++++:++++++++:. .:++::+=o=======|
> > > ==o====~~~~~:::.   .:::++++=+=+++:+++++++=+=+++++++: .~~+=:::=========|
> > > ooo=oo=:~~~:~::  ..~~~:::+++++++++=+=++++++=++++:+:..~~~:+:~:===o=o=oo|
> > > =o===o+:~~::~:.. ....~~~::+++++:~~:++::::++:+:+::+:  .:::++~:+=ooooooo|
> > > o=ooo=+:.::~~~. ...  .~~~:::::+:::~~~:::++++:::::::  ~::::=:~+=o=ooooo|
> > > ooo=o+++:~~~~... ..  .~~~::::+++++++++++++:::++::::  ~+:+:+~~:+o=oo=o=|
> > > o=o=++==:~~..~.   .   ~~~:::::~~~:~~~~~:~~:::+::::~ .:::::+~.:+=o==o=o|
> > > =o=+====:~.....        ~~~:::+:::~:::::::+++:::::~  .+:~:++.~~+=oooooo|
> > > ====o==++:~.~~~...      .~~~~:::+::::::+:+:+::::.   :+:::+:.~:+=======|
> > > o=====+=+=+~~~~...       .~~:::::++++++++:+:::~ .  .::++::~:::+==o====|
> > > o==oo+=+=o=:::~~.        .~..~~:++:++++++::~~..~...::+++++::+++=====o=|
> > > =o====o=o=++::~.         .~~~...~::::::::~...~~~~.~:+++++++++++==o==o=|
> > > oo===oo=o=+:~~....       ~~~:~~~..........~~:::~~..:+++++++++===oooo=o|
> > > =o===oo=+::~~~..         ~~~::~~~~~~~~~~~~:~~::~~~~~+++++++++====ooooo|
> > > ====++::~....... ..    ~~:::~::::::~~~~~~~:~::::~.. .=+++=+=+====o=oo=|
> > > ==+:~~........  .. ...~:::::::::::::::~~::::::::~.  .~+==++=++o===o=oo|
> > > oo+..         ~~~~~:~::+::::::::::::::::::::::::~. ~:~~:=++=+==+==oooo|
> > > =+:~~.    .~~~:+::::+++:+::++::+:+:+:++:++:++:::~..+:.~::++++++++++==:|
> > 
> > +----------------------------------------------------------------------+
> > 
> > Signed-off-by: Michael Neuling <mikey at neuling.org>
> 
> What are you doing here? This is just unprofessional.
> 
> Enthusiastically-NAKed-by: Oliver O'Halloran <oohall at gmail.com>

:-)

> > +       psi_set_external_irq_policy(EXTERNAL_IRQ_POLICY_LINUX);
> 
> I think this can be removed. As far as I can tell this only affects
> psi_p8_irq_attributes() which shouldn't be called on P9. I sent a
> fixup a while ago for Zaius, but I think it's somewhere far down the
> patch queue.

OK thanks.  

I've Acked your zaius patch to help pull it up the patch queue.  I'll repost
this.

Mikey


More information about the Skiboot mailing list