[Skiboot] [PATCH v5 1/8] skiboot: Nest IMC macro definitions

Oliver O'Halloran oohall at gmail.com
Fri Feb 10 18:01:42 AEDT 2017


On Wed, 2017-02-08 at 02:41 +0530, Hemant Kumar wrote:
> Add the macros needed for Nest IMC (In Memory Collection)
> instrumentation support by creating a new file in include/ called
> "imc.h". Also, add a header "nest_imc.h" containing an array of
> possible list of nest PMUs. These macros are needed to discover the
> catalog subpartition, enable and disable the nest IMC
> instrumentation.
> 
> Signed-off-by: Hemant Kumar <hemant at linux.vnet.ibm.com>
> ---
> Changelog :
> v2 -> v3:
>  - Changed references from IMA to IMC.
>  - Removed the macro defintions for the nest PMU names since, they
> were not
>    used anywhere except for the availability array.
>  - Spell corrections.
> v1 -> v2:
>  - Changed macro names SLW_IMA_* to NEST_IMA_*.
>  - Also, added a couple of new members to the IMA control block
> struct.
>    One for run_mode and another for nest IMA PMU availability.
>  - Added a new file which contains the nest IMA PMUs names and their
>    definitions (will be used to check the availability).
> 
>  include/imc.h      | 115
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  include/nest_imc.h |  85 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 200 insertions(+)
>  create mode 100644 include/imc.h
>  create mode 100644 include/nest_imc.h
> 
> diff --git a/include/imc.h b/include/imc.h
> new file mode 100644
> index 0000000..d6f765a
> --- /dev/null
> +++ b/include/imc.h
> @@ -0,0 +1,115 @@
> +/* Copyright 2016 IBM Corp.
> + *
> + * Licensed under the Apache License, Version 2.0 (the "License");
> + * you may not use this file except in compliance with the License.
> + * You may obtain a copy of the License at
> + *
> + *	http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> + * implied.
> + * See the License for the specific language governing permissions
> and
> + * limitations under the License.
> + */
> +
> +/*
> + * IMC (In-Memory Collection) :
> + * Power9 has IMC instrumentation support with which several metrics
> of the
> + * platform can be monitored. These metrics are backed by the
> + * Performance Monitoring Units (PMUs) and their counters.
> + * IMC counters run continuously from startup to shutdown and hence,
> the
> + * name and data from these counters are fed directly into a pre-
> defined
> + * memory location.
> + *
> + * Depending on the counters' location and monitoring engines, they
> are
> + * classified into three domains :
> + * Nest IMC, core IMC and thread IMC.
> + *
> + * Nest Counters :
> + * Nest counters are per-chip counters and can help in providing
> utilisation
> + * metrics like memory bandwidth, Xlink/Alink bandwidth etc.
> + * A microcode in OCC programs the nest counters and moves counter
> values to
> + * per chip HOMER region in a fixed offset for each unit. Engine has
> a
> + * control block structure for communication with Hypervisor(Host
> OS).
> + */
> +
> +#ifndef __IMC_H
> +#define __IMC_H
> +
> +/*
> + * Control Block structure offset in HOMER nest Region
> + */
> +#define CB_STRUCT_OFFSET	0x39FC00
> +#define CB_STRUCT_CMD		0x39FC08
> +#define CB_STRUCT_SPEED		0x39FC10
> +#define NEST_IMC_PAUSE		0x2
> +#define NEST_IMC_RESUME		0x1
> +#define NEST_IMC_NOP		0
> +
> +/*
> + * Control Block Structure:
> + *
> + * Name          Producer        Consumer        Values  Desc
> + * IMCRunStatus   IMC
> Code       Hypervisor      0       Initializing
> + *                               (Host OS)       1       Running
> + *                                               2       Paused
> + *
> + * IMCCommand     Hypervisor     IMC Code        0       NOP
> + *                                               1       Resume
> + *                                               2       Pause
> + *                                               3       Clear and
> Restart
> + *
> + * IMCCollection Hypervisor      IMC Code        0       128us
> + * Speed					 1       256us
> + *                                               2       1ms
> + *                                               3       4ms
> + *                                               4       16ms
> + *                                               5       64ms
> + *                                               6       256ms
> + *                                               7       1000ms
> + *
> + * IMCAvailability IMC Code      Hypervisor      -       64-bit
> value describes
> + *                                                       the Vector
> Nest PMU
> +
> *                                                       availability.
> + *                                                       Bits 0-47
> denote the
> +
> *                                                       availability
> of 48 different
> + *                                                       nest units.
> + *                                                       Rest are
> reserved. For details
> + *                                                       regarding
> which bit belongs
> + *                                                       to which
> unit, see
> +
> *                                                       include/nest_
> imc.h.
> + *                                                       If a bit is
> unset (0),
> + *                                                       then, the
> corresponding unit
> + *                                                       is
> unavailable. If its set (1),
> + *                                                       then, the
> unit is available.
> + *
> + * IMCRun Mode    Hypervisor     IMC Code        0       Normal Mode
> (Monitor Mode)
> + *                                               1       Debug Mode
> 1 (PB)
> + *                                               2       Debug Mode
> 2 (MEM)
> + *                                               3       Debug Mode
> 3 (PCIE)
> + *                                               4       Debug Mode
> 4 (CAPP)
> + *                                               5       Debug Mode
> 5 (NPU 1)
> + *                                               6       Debug Mode
> 6 (NPU 2)
> + */
> +struct imc_chip_cb
> +{
> +	u64 imc_chip_run_status;
> +	u64 imc_chip_command;
> +	u64 imc_chip_collection_speed;
> +	u64 imc_chip_avl_vector;
> +	u64 imc_chip_run_mode;
> +};
> +
> +/* Size of IMC dtb LID (256KBytes) */
> +#define IMC_DTB_SIZE		0x40000
> +
> +/*
> + * Nest IMC operations
> + */
> +#define NEST_IMC_PRODUCTION_MODE	0x1
> +#define NEST_IMC_ENABLE			0x1
> +#define NEST_IMC_DISABLE		0x2
> +
> +#endif /* __IMC_H */
> diff --git a/include/nest_imc.h b/include/nest_imc.h
> new file mode 100644
> index 0000000..9e519ac
> --- /dev/null
> +++ b/include/nest_imc.h
> @@ -0,0 +1,85 @@
> +/* Copyright 2016 IBM Corp.
> + *
> + * Licensed under the Apache License, Version 2.0 (the "License");
> + * you may not use this file except in compliance with the License.
> + * You may obtain a copy of the License at
> + *
> + *	http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> + * implied.
> + * See the License for the specific language governing permissions
> and
> + * limitations under the License.
> + */
> +
> +#ifndef __NEST_IMC_H
> +#define __NEST_IMC_H
> +
> +/*
> + * Nest IMC PMU names along with their bit values as represented in
> the
> + * imc_chip_avl_vector(in struct imc_chip_cb, look at
> include/imc.h).
> + */
> +
> +#define MAX_AVL		48
> +/* Reserved bits : 48-64 */
> +
> +/*
> + * Nest IMC PMU names along with their bit values as represented in
> the
> + * imc_chip_avl_vector(in struct imc_chip_cb, look at
> include/imc.h).
> + * nest_pmus[] is an array containing all the possible nest IMC PMU
> node names.
> + */
> +char const *nest_pmus[] = {
> +	"pb",
> +	"mcs0",
> +	"mcs1",
> +	"mcs2",
> +	"mcs3",
> +	"mcs4",
> +	"mcs5",
> +	"mcs6",
> +	"mcs7",
> +	"mba0",
> +	"mba1",
> +	"mba2",
> +	"mba3",
> +	"mba4",
> +	"mba5",
> +	"mba6",
> +	"mba7",
> +	"cen0",
> +	"cen1",
> +	"cen2",
> +	"cen3",
> +	"cen4",
> +	"cen5",
> +	"cen6",
> +	"cen7",
> +	"xlinks0",
> +	"xlinks1",
> +	"xlinks2",
> +	"mcd0",
> +	"mcd1",
> +	"phb0",
> +	"phb1",
> +	"phb2",
> +	"resvd",
> +	"nx",
> +	"capp0",
> +	"capp1",
> +	"vas",
> +	"int",
> +	"alinks0",
> +	"alinks1",
> +	"alinks2",
> +	"nvlinks0",
> +	"nvlinks1",
> +	"nvlinks2",
> +	"nvlinks3",
> +	"nvlinks4",
> +	"nvlinks5",
> +	/* reserved bits : 48 - 64 */
> +};
> +
> +#endif /* __NEST_IMC_H */

These could probably go into a single header file. Looks fine
otherwise.

Reviewed-by: Oliver O'Halloran <oohall at gmail.com>


More information about the Skiboot mailing list