[Skiboot] [PATCH 5/5] hdat: Fix interrupt & device_type of UART node

Benjamin Herrenschmidt benh at kernel.crashing.org
Fri Feb 3 20:52:00 AEDT 2017


The interrupt should use a standard "interrupts" property. The UART
node also need a device_type="serial" property for historical reasons
otherwise Linux won't pick it up.

Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
---
 hdata/fsp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hdata/fsp.c b/hdata/fsp.c
index 998724b..f44f6a9 100644
--- a/hdata/fsp.c
+++ b/hdata/fsp.c
@@ -264,8 +264,10 @@ static void add_uart(const struct spss_iopath *iopath, struct dt_node *lpc)
 		be32_to_cpu(iopath->lpc.uart_baud));
 	dt_add_property_cells(serial, "clock-frequency",
 		be32_to_cpu(iopath->lpc.uart_clk));
-	dt_add_property_cells(serial, "serirq-interrupt",
+	dt_add_property_cells(serial, "interrupts",
 		be32_to_cpu(iopath->lpc.uart_int_number));
+	dt_add_property_string(serial, "device_type", "serial");
+
 
 	prlog(PR_DEBUG, "LPC UART: base addr = %#" PRIx64" (%#" PRIx64 ") size = %#x clk = %u, baud = %u\n",
 		be64_to_cpu(iopath->lpc.uart_base),
-- 
2.9.3



More information about the Skiboot mailing list