[Skiboot] [PATCH 2/3] Introduce NPU2 support

[Alistair Popple]

> > +		/*
> > +		 * Put start address bits 49:24 into TVE[52:53]||[0:23]
> > +		 * and end address bits 49:24 into TVE[54:55]||[24:47]
> > +		 * and set TVE[51]
> > +		 */
> > +		tve  = (pci_start_addr << 16) & (0xffffffull << 48);
>
> I think it should be:
> tve  = (pci_start_addr << 16) & (0xffffffull << 40);
>
> See http://patchwork.ozlabs.org/patch/710557/

Thanks Fred. I agree, will fix in the next patch revision.

It also needs fixing in hw/phb3.c and hw/npu.c right?

- Alistair

>
>    Fred
>
> > +		tve |= (pci_start_addr >> 38) & (3ull << 10);
> > +		tve |= (end >>  8) & (0xfffffful << 16);
> > +		tve |= (end >> 40) & (3ull << 8);
> > +		tve |= PPC_BIT(51);
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
>