[Skiboot] [PATCH 1/9] npu2: Split out common helper functions into separate file

Alistair Popple alistair at popple.id.au
Fri Dec 22 15:28:11 AEDT 2017

On Friday, 22 December 2017 3:22:32 PM AEDT Stewart Smith wrote:
> Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
> > On 19/12/17 11:37, Alistair Popple wrote:
> >>> +bool is_p9dd1(void)
> >> 
> >> Does OpenCAPI still need this? If not we should just drop it and DD1 support
> >> along with it as it's very unlikely anything still works there.
> >
> > OpenCAPI has no DD1 support whatsoever. If you want to drop DD1 support 
> > for NVLink then I have no objections!
> I have no objection to this.
> Anyone currently attempting NVLink on DD1 gets all the checkstops they deserve.

Yep. I'm going to pull it out. Although it may just lead to xstops on boot for
DD1 ... is that something we care about or should we still detect DD1 and
disable NVLink (which would prevent any checkstops)?

- Alistair


More information about the Skiboot mailing list