[Skiboot] [PATCH v2 1/2] opal/xscom: Move the delay inside xscom_reset() function.

Vaidyanathan Srinivasan svaidy at linux.vnet.ibm.com
Wed Dec 13 18:50:52 AEDT 2017


* Stewart Smith <stewart at linux.vnet.ibm.com> [2017-12-13 14:09:47]:

> Mahesh J Salgaonkar <mahesh at linux.vnet.ibm.com> writes:
> > From: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> >
> > So caller of xscom_reset() does not have to bother about adding a delay
> > separately. Instead caller can control whether to add a delay or not using
> > second argument to xscom_reset().
> >
> > Signed-off-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>

Reviewed-by:  Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com>

> > ---
> > Changes in V2:
> > - Add a bool argument to xscom_reset() to give the control to caller whether to
> >   delay is required or not after reset.
> > ---
> >  hw/xscom.c |   39 +++++++++++++++++++++------------------
> >  1 file changed, 21 insertions(+), 18 deletions(-)
> 
> Thanks, series merged to master as of
> 10f0a09239ddfd4faf47d792f04d3124fb347f88
> 
> Let me know if this should head to 5.9.x or not. Currently I haven't
> cherry picked it back.

Yes Stewart, we need this in 5.9.x for all P9 systems. Kindly pick
this xscom recovery for skiboot stable also.

Thanks,
Vaidy



More information about the Skiboot mailing list