[Skiboot] [PATCH v2 2/5] xive: Do not return a trigger page for an escalation interrupt

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue Dec 12 16:22:52 AEDT 2017


This is bogus, we don't support them. (Thankfully the callers
didn't actually try to use this on escalation interrupts).

Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Tested-by: Oliver O'Halloran <oohall at gmail.com>
---
 hw/xive.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/xive.c b/hw/xive.c
index 364be549..76939b79 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -2111,8 +2111,8 @@ void *xive_get_trigger_port(uint32_t girq)
 		return NULL;
 
 	if (GIRQ_IS_ESCALATION(girq)) {
-		/* Page 2 of the EQ MMIO space is the escalate irq */
-		return x->eq_mmio + idx * 0x20000 + 0x10000;
+		/* There is no trigger page for escalation interrupts */
+		return NULL;
 	} else {
 		/* Make sure it's an IPI on that chip */
 		if (girq < x->int_base ||
-- 
2.14.3



More information about the Skiboot mailing list