[Skiboot] [PATCH] pflash: Support for clean_on_ecc_error flag

[Stewart Smith]

Adriana Kobylak <anoo at linux.vnet.ibm.com> writes:
> Add the misc flag clear_on_ecc_error to libflash/pflash. This was
> the only missing flag. The generator of the virtual pnor image
> relies on libflash/pflash to provide the partition information,
> so all flags are needed to build an accurate virtual pnor partition
> table.
>
> Signed-off-by: Adriana Kobylak <anoo at linux.vnet.ibm.com>
> ---
>  external/ffspart/ffspart.c                    |  3 +++
>  external/pflash/pflash.c                      | 16 +++++++++-------
>  external/pflash/test/files/06-miscprint.ffs   |  1 +
>  external/pflash/test/results/01-info.out      | 17 +++++++++--------
>  external/pflash/test/results/06-miscprint.out |  9 +++++++++
>  libflash/ffs.h                                |  1 +
>  libflash/libffs.c                             |  3 +--
>  libflash/libffs.h                             |  1 +
>  8 files changed, 34 insertions(+), 17 deletions(-)

This seems to break "make check" for me

running test/tests/00-usage
running test/tests/01-info
--- test/results/01-info.out	2017-12-12 11:07:11.350286083 +1100
+++ -	2017-12-12 11:07:35.633697095 +1100
@@ -12,4 +12,3 @@
 ID=03           THREE 0x00005000..0x00006000 (actual=0x00001000) [E---F--]
 ID=04            FOUR 0x00006000..0x00007000 (actual=0x00001000) [E---F--]
 ID=05            FIVE 0x00007000..0x00008000 (actual=0x00001000) [-----V-]
-ID=06             SIX 0x00008000..0x00009000 (actual=0x00001000) [------C]
test/test-pflash (01-info): test failed
Test directory preserved:
  DATA_DIR = /tmp/external-test-datadir.dpunHv
  STDOUT = /tmp/external-test-datadir.dpunHv/stdout
  STDERR = /tmp/external-test-datadir.dpunHv/stderr
make[1]: Leaving directory '/home/stewart/skiboot/external/pflash'
make: *** [/home/stewart/skiboot/external/Makefile.check:18: check-pflash] Error 2
make: *** Waiting for unfinished jobs....

Looks like something is missing from
external/pflash/test/files/01-info.ffs ?

Can you respin with that missing bit? Otherwise looks okay.

-- 
Stewart Smith
OPAL Architect, IBM.