[Skiboot] [PATCH v3 20/29] asm/head: add entry/exit calls
Stewart Smith
stewart at linux.vnet.ibm.com
Thu Dec 7 10:57:17 AEDT 2017
Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> On Wed, 2017-11-29 at 15:36 +1000, Nicholas Piggin wrote:
>> +void opal_exit_check(int64_t retval, struct stack_frame *eframe);
>> +
>> +void __attrconst opal_exit_check(int64_t retval, struct stack_frame *eframe)
>> +{
>> + (void)retval;
>> + (void)eframe;
>> }
>>
>
> Won't that corrupt r3 ?
>
> We should return retval. This caused all sort of failures including
> failure to init the console with DEBUG=1 builds for me unless I fix it.
>
> Patch on the way...
https://patchwork.ozlabs.org/patch/845034/ merged with the fix.
--
Stewart Smith
OPAL Architect, IBM.
More information about the Skiboot
mailing list