[Skiboot] [PATCH v2] hw/imc: Check ucode state in all the chip

Stewart Smith stewart at linux.vnet.ibm.com
Thu Dec 7 08:36:19 AEDT 2017

Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
> disable_unavailable_units() checks whether the ucode
> is in the running state before enabling the nest units
> in the device tree. From a recent debug, it is found
> that on some system boot, ucode is not loaded and
> running in all the chips in the system. And this
> caused a fail in OPAL_IMC_COUNTERS_STOP call where
> we check for ucode state on each chip. Bug here is
> that disable_unavailable_units() checks the state
> of the ucode only in boot cpu chip. Patch adds a
> condition in disable_unavailable_units() to check
> for the ucode state in all the chip before enabling
> the nest units in the device tree node.
> Fixes: f98d59958db19 ('skiboot: Find the IMC DTB')
> Signed-off-by: Madhavan Srinivasan <maddy at linux.vnet.ibm.com>

Thanks - as discussed on Slack, merged with slight modification in order
to clarify why we're disabling everything rather than just one chip.

Merged to master as of 3647e9850660206f862cecad5abe62943ea727a1

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list