[Skiboot] [PATCH 4/6] xive: Use io_complete() when changing the ESB mask bits

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Dec 7 04:39:26 AEDT 2017


Thus ensuring that the load has completed before anything else
is done (ie, the interrupt is actually masked).

Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
---
 hw/xive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xive.c b/hw/xive.c
index 76939b79..104e1e85 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -2451,7 +2451,7 @@ static void xive_update_irq_mask(struct xive_src *s, uint32_t idx, bool masked)
 	if (s->flags & XIVE_SRC_SHIFT_BUG)
 		offset <<= 4;
 
-	in_be64(mmio_base + offset);
+	in_complete(in_be64(mmio_base + offset));
 }
 
 static int64_t xive_sync(struct xive *x)
-- 
2.14.3



More information about the Skiboot mailing list