[Skiboot] [RFC PATCH 00/13] Rework flash TOC generation

[Stewart Smith]

Cyril Bur <cyril.bur at au1.ibm.com> writes:
> On Mon, 2017-12-04 at 16:34 +1100, Stewart Smith wrote:
>> Cyril Bur <cyril.bur at au1.ibm.com> writes:
>> > > how close is this to being able to produce a binary identical FFS image
>> > > to the existing tooling?
>> > > 
>> > 
>> > I'm pretty sure that at time of posting, it was identical to what I
>> > could wget from openpower.xyz as build pnors. In previous iterations of
>> > this patch it was also true, and things magically changed...
>> > 
>> > Definitely worth a recheck - perhaps I could add it as part of a test.
>> > Bit of a wget and diff situation, that might be fragile because the XML
>> > would need to be converted
>> 
>> 
>> Sounds fragile :)
>> 
>> If we just did it once and added a test with that layout and checking
>> the bits matched, I'd be happy.
>> 
>
> Ah but need all the intermediary build files - arg that test is
> becoming a bit of a nightmare to write.
>
> Maybe get op-build to use both methods for a while and always compare
> the results, would be much less of a headache.

Yeah, I wouldn't be opposed to that as an interim solution.

Of course, that still means we have to work out WTF it's doing and
replicate it :)


-- 
Stewart Smith
OPAL Architect, IBM.