[Skiboot] [RFC PATCH 00/13] Rework flash TOC generation

[Stewart Smith]

Cyril Bur <cyril.bur at au1.ibm.com> writes:
>> how close is this to being able to produce a binary identical FFS image
>> to the existing tooling?
>> 
>
> I'm pretty sure that at time of posting, it was identical to what I
> could wget from openpower.xyz as build pnors. In previous iterations of
> this patch it was also true, and things magically changed...
>
> Definitely worth a recheck - perhaps I could add it as part of a test.
> Bit of a wget and diff situation, that might be fragile because the XML
> would need to be converted


Sounds fragile :)

If we just did it once and added a test with that layout and checking
the bits matched, I'd be happy.

>> We have a different CSV format for FFS in phosphor-mboxd too, perhaps
>> Adriana can chime in if it's possible/plausible to move to just one
>> representation, as this could help simplify our PNOR building process.
>> 
>
> Hmm I remember thinking that the phosphor-mbox CSV was pretty close. Of
> course its possible that the one here grew a bit in complexity.

Yeah, the multiple flash sides and all that probably made things
horrific :)

>> I'd *really* like to rip out openpower-ffs and other related crap from
>> the op-build process and just replace it with this, largely because this
>> has a remote chance of being maintained and a remote chance of not
>> bringing in 13,000 lines of useless junk with it.
>> 
>
> Strong ack!
>
>> In theory at least, ffspart ond the openbmc image building utility could
>> just take the same input and output a different image.
>> 
>

-- 
Stewart Smith
OPAL Architect, IBM.