[Skiboot] [PATCH] core/init: Fix failure of getting node in the free list.

Stewart Smith stewart at linux.vnet.ibm.com
Wed Sep 28 17:09:34 AEST 2016


ppaidipe at linux.vnet.ibm.com writes:
> From: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
>
> Currently we are getting request to queue occ load opal message when host services
> got load occ request from FSP. This request we got before initializing opal messaging
> due to which we are failed to get list node from msg_free_list list.
>
> [3204300512,3] opalmsg: No available node in the free list, allocating
>
> This patch fixes this issue by initializing opal messaging(opal_init_msg) before
> platform.init, as in platform.init we are loading host services lid and getting
> occ load request command from FSP. So when opal_init_msg initializes we will
> be initialized msg_free_list with an empty list.

Thanks!

Works and looks safe. Merged to master as of
564ed2a8caadc6b4e858bc7933131ed27ba9f13a

I think this clears us up to eliminate the allocation of new messages
and instead throw an error - as continually allocating them has led us
down a bad path in the past.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list