[Skiboot] [PATCH v3] flash: Move flash node under ibm, opal/flash/

Stewart Smith stewart at linux.vnet.ibm.com
Tue Sep 27 17:09:04 AEST 2016


Jack Miller <jack at codezen.org> writes:
> This changes the boot ABI, so it's only active for P9 and later systems,
> even though it's unrelated to hardware changes. There is an associated
> Linux change to properly search for this node as well.
>
> This change properly specifies #address-cells for the flash node, so we
> can avoid DTC errors like
>
> ---
> device tree: Warning (reg_format): "reg" property in /ibm,opal/flash at 0
> has invalid length (8 bytes) (#address-cells == 0, #size-cells == 0)
> ---
>
> Base on a patch from Cyril Bur
>
> Signed-off-by: Jack Miller <jack at codezen.org>
> ---
>  core/flash.c | 31 ++++++++++++++++++++++++-------
>  1 file changed, 24 insertions(+), 7 deletions(-)

While I'm not convinced that /ibm,opal/flash/flash at foo is the most
correct location, the kernel patches that just search for compatible
make it not erally matter, and not part of ABI.

So, merged to master as of e1e6d009860d0ef60f9daf7a0fbe15f869516bd0.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list