[Skiboot] [PATCH v4] occ/prd/opal-prd: Queue OCC_RESET event message to host in OpenPOWER

Stewart Smith stewart at linux.vnet.ibm.com
Tue Sep 27 17:04:50 AEST 2016


Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com> writes:
> During an OCC reset cycle the system is forced to Psafe pstate.
> When OCC becomes active, the system has to be restored to its
> last pstate as requested by host. So host needs to be notified
> of OCC_RESET event or else system will continue to remian in
> Psafe state until host requests a new pstate after the OCC
> reset cycle.
>
> This patch defines 'OPAL_PRD_MSG_TYPE_OCC_RESET_NOTIFY' to
> notify OPAL when opal-prd issues OCC reset. OPAL will queue
> OCC_RESET message to host when it receives opal_prd_msg of
> type '*_OCC_RESET_NOTIFY'.
>
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com>
> ---
> - No changes from v3, rebased on master.
>
> Changes from v2:
> - Fixed the wrong message argument passed to write() in
>   handle_prd_control() function in opal-prd.c
>   - rc = write(ctx->fd, &msg, sizeof(omsg));
>   + rc = write(ctx->fd, &omsg, sizeof(omsg));
>
> Changes from v1:
> - Modified commit log
> - s/OPAL_PRD_MSG_TYPE_OCC_RESET_NOTIF/OPAL_PRD_MSG_TYPE_OCC_RESET_NOTIFY
>
>  external/opal-prd/opal-prd.c |  6 +++++
>  hw/occ.c                     | 56 ++++++++++++++++++++++++++------------------
>  hw/prd.c                     |  4 ++++
>  include/opal-api.h           |  1 +
>  include/opal-internal.h      |  1 +
>  5 files changed, 45 insertions(+), 23 deletions(-)

Sorry for the delay in merging, tested it out in a variety of situations
and looks good. Is this something that should also head to stable?

Merged to master as of b5e54375bdc424eb2e709d41d2306d854f7e07bb

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list