[Skiboot] [PATCH] external: Use more-standard PREFIX vs prefix

Stewart Smith stewart at linux.vnet.ibm.com
Thu Sep 22 16:09:56 AEST 2016


Patrick Williams <patrick at stwcx.xyz> writes:
> On Fri, Aug 05, 2016 at 04:06:57PM -0500, Patrick Williams wrote:
>> Distro packaging tools typically use PREFIX instead of prefix,
>> so change all references to lower-case prefix to upper-case.
>> 
>> pflash uses PREFIX since at least b2649b.
>> 
>> Signed-off-by: Patrick Williams <patrick at stwcx.xyz>
>> ---
>
> After I wrote this patch and cross-referenced with the existing openbmc
> bitbake recipe, I'm not convinced that "PREFIX" or "prefix" is any more
> standard than the other.  Maybe someone else can speak to that.

https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Installation-Directory-Variables.html
and
https://www.gnu.org/software/automake/manual/html_node/Standard-Directory-Variables.html

all point to prefix rather than PREFIX, so maybe we should go that way.

I'll send a patch, feel free to try it out and review/ack/nak depending
on result :)


-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list