[Skiboot] [RFC PATCH 3/5] hdat: parse and export STOP levels
oohall at gmail.com
Sat Sep 17 12:41:36 AEST 2016
On Fri, Sep 16, 2016 at 7:06 PM, Vasant Hegde
<hegdevasant at linux.vnet.ibm.com> wrote:
> On 09/16/2016 12:15 PM, Oliver O'Halloran wrote:
>> ISAv3 added the STOP instruction to act as a front end to the various
>> power saving modes. The exact function of the stop instruction is
>> implementation dependent and the firmware must advertise which "stop
>> levels" are supported.
>> This patch adds the required HDAT parsing and exports the
>> "ibm,enabled-stop-levels" devicetree node for use inside of skiboot.
> Patch looks good. But probably its better to fold patch 3 & 4. Otherwise we
> may hit issues during git bisect...
I'd rather they remained seperate. I'll re-order the series so patch 4
comes before 3. That way we should never bisect to a broken state.
> Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
More information about the Skiboot