[Skiboot] [PATCH 1/2] opal-prd: Add get_prd_flags to host interfaces

Jeremy Kerr jk at ozlabs.org
Wed Sep 14 10:43:10 AEST 2016


Hi Dan,

> Also, it doesn't seem like we're planning to support a feature list
> here, so maybe the name should reflect that this is really just to
> handle fixes.

Yes, this is intended to cover more than fixes; "capabilities" would be
a better term here.

For example, if this was present during the change to add the 'instance'
parameter to get_reserved_mem(), we would have indicated this as a
capability bit. [It so happened that the semantics of the call meant
could implement that in an ABI-backwards-compatible way, but we got
lucky with that]

So, how is:

  get_interface_capabilities()

?

> Remember that we support PHYP now with the same code so we have to think
> commonality.  I'll assume that the master copy (steady state) of these
> flags will be the version inside of the hostboot code.

Yep, we'd need to keep that in sync.

Cheers,


Jeremy


More information about the Skiboot mailing list