[Skiboot] [PATCH] slw: improve error message for SLW timer stuck
Stewart Smith
stewart at linux.vnet.ibm.com
Fri Sep 9 14:09:46 AEST 2016
Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com> writes:
> Hi Stewart,
>
> On 09/08/2016 07:20 AM, Stewart Smith wrote:
>> + * operations (for example). It may also
>> + * increase jitter, as more time is spent
>> + * inside OPAL every time a timer is requested
>> + * and we time out after 1ms.
>
> This error sets 'slw_has_timer' to false, which disables queuing of new timers
> and thus we wont be in the timeout loop after this error. So this error will not
> bring in any new jitter.
Good point! Maybe I should have payed attention to the code a bit more
when I wrote the text. I blame early morning meetings and insufficient
coffee.
Fixed in V2.
--
Stewart Smith
OPAL Architect, IBM.
More information about the Skiboot
mailing list