[Skiboot] [PATCH v2 0/3] Support PCI Virtual Device
alistair at popple.id.au
Wed Sep 7 16:50:10 AEST 2016
On Thu, 11 Aug 2016 12:12:35 PM Gavin Shan wrote:
> The patches support PCI virtual device. The NVLinks are presented to Linux
> kernel via PCI virtual (emulated) device. As we're going to support NVLink2
> pretty soon, we need support PCI virtual device in common layer so that it
> can be shared by NVLINK1/2.
> v1 -> v2:
> * Rebased to master branch per requested by Stewart. No code changes
> since v1. The last commit is f102c9d19078 ("Merge skiboot-5.3.1
> release notes").
> * Had quick test on Garrison1 and no obvious issues found.
We should run actual GPU workloads to test any NPU changes (eg. a CUDA
bandwidth test - let me know if you're not sure how). A simple boot test is
not enough as it won't exercise many of the code paths that have been changed
here. It seems patch 3 breaks something as the nVidia driver no longer works
with nvlink on master - could you please take a look at this? Thanks!
Stewart - we may need to revert "[PATCH v2 3/3] hw/npu: Use PCI virtual
device" if we can't get this fixed soon - will let you know.
> Gavin Shan (3):
> core/pci: Improve PCI config register filter
> core/pci: Support virtual device
> hw/npu: Use PCI virtual device
> core/Makefile.inc | 6 +-
> core/pci-virt.c | 260 ++++++++++++++++++++++++++++
> hw/npu-hw-procedures.c | 32 ++--
> hw/npu.c | 450
> hw/phb3.c | 14 +-
> include/npu.h | 22 +--
> include/pci-virt.h | 85 ++++++++++
> include/pci.h | 9 +-
> 8 files changed, 518 insertions(+), 360 deletions(-)
> create mode 100644 core/pci-virt.c
> create mode 100644 include/pci-virt.h
More information about the Skiboot