[Skiboot] [PATCH] hw/npu.c: NPU bdfn allocation bugfix

Stewart Smith stewart at linux.vnet.ibm.com
Tue Sep 6 17:13:32 AEST 2016

Alistair Popple <alistair at popple.id.au> writes:
> The bdfn of the emulated/fake nvlink PCIe devices is allocated based
> on the topology of GPU connections. Nvlinks going to the same GPU are
> allocated to unique functions within the same device number.
> In the device-tree every collection of nvlinks going to the same GPU
> are given a unique group number which is currently also used as the
> device number. To allocate a sequentially unique function number the
> code should find the maximum previously allocated function.
> However currently the code only checks for a single previously
> allocated function number. This works fine on Garrison systems which
> only have two links per GPU, but other systems may have more links per
> GPU which will result in several links being assigned an identical
> function number, resulting boot failure.
> Signed-off-by: Alistair Popple <alistair at popple.id.au>
> ---
>  hw/npu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Thanks, merged to master as of d4b92ad3328c1dd332a18fe6de6751198d8de2ab
Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list