[Skiboot] [PATCH 01/15] doc/device-tree: Add ibm, secureboot.txt

[Balbir Singh]

On 02/09/16 14:02, Claudio Carvalho wrote:
> 
> 
> On 09/01/2016 08:41 PM, Balbir Singh wrote:
>>
>>
>> On 11/08/16 15:23, Claudio Carvalho wrote:
>>> This adds a documentation for the ibm,secureboot device tree node.
>>>
>>> Signed-off-by: Claudio Carvalho <cclaudio at linux.vnet.ibm.com>
>>> ---
>>>  doc/device-tree/ibm,secureboot.txt | 42 ++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 42 insertions(+)
>>>  create mode 100644 doc/device-tree/ibm,secureboot.txt
>>>
>>> diff --git a/doc/device-tree/ibm,secureboot.txt b/doc/device-tree/ibm,secureboot.txt
>>> new file mode 100644
>>> index 0000000..387cb25
>>> --- /dev/null
>>> +++ b/doc/device-tree/ibm,secureboot.txt
>>> @@ -0,0 +1,42 @@
>>> +Device tree bindings for ibm,secureboot
>>> +=======================================
>>> +
>>> +This node represents the presence of the ROM verification code in the
>>> +platform. It has properties related to secure boot and trusted boot.
>>> +
>>> +Required properties
>>> +-------------------
>>> +
>>> +- compatible :  ibm,secureboot version. It is related to the ROM verification
>>> +		code version.
>>> +
>>> +- hash-algo : 	hash algorithm used for the hw-key-hash. Aspects such as the
>>> +		size of the hw-key-hash can be infered from this property.
>>> +
>>> +- secure-enabled : this property exists whether the system is booting on
>>> +		   secure mode.
>>
>> I think the enabled explains that it is booted with enabled. May be the
>> documentation should first introduce what issecure boot ad then 
>> explain the enabled property
> 
> Secure boot and trusted boot are documented in a separate file, which is
> added by the patch:
> 
> "[PATCH 03/15]doc: Add initial secure and trusted boot documentation"
> 
> Stewart also asked some questions about this patch. I've just answered
> his questions and also proposed a few paragraphs to replace the first one.


Thanks, I did look at ti right now, its good to have the documentation
in the right order in the patch series.

Balbir