[Skiboot] [PATCH v2 0/5] Default access by MTD

Stewart Smith stewart at linux.vnet.ibm.com
Tue Oct 25 20:26:56 AEDT 2016


Cyril Bur <cyril.bur at au1.ibm.com> writes:
> This is what I get for sending patches after 5pm on a Friday. I
> noticed in patch 3/5:
>
> common/arch_flash_powerpc.c: In function ‘arch_flash_access’:
> common/arch_flash_powerpc.c:221:1: warning: control reaches end of
> non-void function [-Wreturn-type]
>
> fixed.
>
> Reworded usage text changes in 5/5
>
> V1 had comments inline in the patches:
> 2/5:
>   Hi Stewart,
>     So this is the 'bug' I mentioned we may want to backport. OpenBMC are
>     going to want patch 5/5 of this series so they'll get this for free, I
>     don't see the point of backporting it for them. I don't know of anyone
>     else building this code from stable releases.
> 5/5:
>   This change is going through testing now. There are still some erasing
>   corner cases that will need to be resolved. The kernel seems happy to
>   use 64K blocks but both the ffs layout and current pflash are very 4K
>   centric, there may be teething issues.

Okay... I trust you'll send along any fixes as needed :)

I'm going to tag a 5.4.0-rc2 on our Wednesday, so there's still time for
fixes.

I'm guessing the OpenBMC folk (i.e Patrick) will just pick up 5.4.0 or
5.4.0-rc2 and run with that.

Anyway,
series merged to master as of f9302f34e1a5501a21f3926d968c2bc0e36f069b

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list