[Skiboot] [PATCH] hw/phb3: improve handling of PHB init failure

Andrew Donnellan andrew.donnellan at au1.ibm.com
Tue Oct 25 14:50:39 AEDT 2016


On 25/10/16 13:29, Andrew Donnellan wrote:
> Is the *current* use of goto error; in the case of a pending transaction
> timeout in PHB3_SLOT_CRESET_WAIT_CQ correct?

After some further discussion with Gavin, we've come to the conclusion 
that it's probably not correct - and indeed with a bit of refactoring we 
can probably get rid of PHB3_STATE_BROKEN completely.

I'll send another patch shortly.

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list