[Skiboot] [PATCH] core/flash: fix part_actual size

Stewart Smith stewart at linux.vnet.ibm.com
Mon Oct 24 21:56:35 AEDT 2016


Claudio Carvalho <cclaudio at linux.vnet.ibm.com> writes:
> The FFS API is not properly setting the part_actual (partition used
> space) for the PNOR partitions at build time. However, skiboot needs
> that to download and consequently measure and verify only the partition
> used space. Currently, the FFS API is setting part_actual=part_size.
>
> This changes the flash_load_resource() to manually calculate the
> part_actual for the requested partition in order to verify and measure
> only the partition used space.
>
> Signed-off-by: Claudio Carvalho <cclaudio at linux.vnet.ibm.com>

I'm getting a problem with unsigned CAPP partition:

/ # grep CAPP /sys/firmware/opal/msglog 
[    4.340500052,7] FLASH: CAPP partition has ECC
[    4.342002343,7] FLASH: CAPP partition isn't signed
[    4.342003640,7] FLASH: flash subpartition eyecatcher CAPP
[    4.342005055,7] FLASH: CAPP partition actual size 0xa000
[    7.076642996,6] CHIP0: CAPP ucode lid loaded at 0x304ca0e0
[    7.076644359,3] PHB#0000: CAPP: ucode header invalid
[    8.114173972,6] CHIP0: CAPP ucode lid loaded at 0x304ca0e0
[    8.114175323,3] PHB#0001: CAPP: ucode header invalid
[    8.480692110,6] CHIP8: CAPP ucode lid loaded at 0x304ca0e0
[    8.480693424,3] PHB#0020: CAPP: ucode header invalid
[    9.437166081,6] CHIP8: CAPP ucode lid loaded at 0x304ca0e0
[    9.437167411,3] PHB#0021: CAPP: ucode header invalid
[   10.271371457,6] CHIP8: CAPP ucode lid loaded at 0SOL session closed by BMC

and yes, I have gotten "SOL session closed by BMC" due to the wonders of
AMI BMC. I have gotten it around 20 times an hour ALL DAY trying to
debug this.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list