[Skiboot] [PATCH v2 0/5] Default access by MTD

Cyril Bur cyril.bur at au1.ibm.com
Mon Oct 24 15:36:45 AEDT 2016


This is what I get for sending patches after 5pm on a Friday. I
noticed in patch 3/5:

common/arch_flash_powerpc.c: In function ‘arch_flash_access’:
common/arch_flash_powerpc.c:221:1: warning: control reaches end of
non-void function [-Wreturn-type]

fixed.

Reworded usage text changes in 5/5

V1 had comments inline in the patches:
2/5:
  Hi Stewart,
    So this is the 'bug' I mentioned we may want to backport. OpenBMC are
    going to want patch 5/5 of this series so they'll get this for free, I
    don't see the point of backporting it for them. I don't know of anyone
    else building this code from stable releases.
5/5:
  This change is going through testing now. There are still some erasing
  corner cases that will need to be resolved. The kernel seems happy to
  use 64K blocks but both the ffs layout and current pflash are very 4K
  centric, there may be teething issues.


Cyril Bur (5):
  libflash/libffs: Use blocklevel_smart_write() when updating partitions
  external/common: arm: Don't error trying to wrprotect with MTD access
  external/common: Rename arch_flash_bmc() to arch_flash_access()
  external/pflash: Catch incompatible combination of flags
  external/pflash: Make MTD accesses the default

 external/common/arch_flash.h         |  6 ++--
 external/common/arch_flash_arm.c     | 15 ++++++----
 external/common/arch_flash_common.c  |  6 ++--
 external/common/arch_flash_powerpc.c | 16 +++++++++++
 external/pflash/pflash.c             | 54 +++++++++++++++++++++---------------
 libflash/libffs.c                    |  2 +-
 6 files changed, 64 insertions(+), 35 deletions(-)

-- 
2.10.1



More information about the Skiboot mailing list