[Skiboot] [PATCH] pci: Check power state before powering off slot

[Stewart Smith]

Gavin Shan <gwshan at linux.vnet.ibm.com> writes:
> I made the inappropriate assumption: PCI slot's power state is
> always on from the beginning. We don't check the slot's power
> state before turning it off in PCI enumeration path when there
> are no PCI adapters behind the slot. The PCI slot's power might
> have been turned off and we needn't power it off again. Otherwise,
> the below (not harmful) message is raised:
>
> [   47.243635711,5] SkiBoot skiboot-5.4.0-rc1 starting...
>        :
> [   13.239871630,5] PHB#0001:02:01.0 Error -1 powering off slot
>
> This checks power state and avoid turning it off again if it's
> already in off state. Flag PCI_SLOT_FLAG_BOOTUP is also removed
> after the requested operation is completed as the flag should
> be used at skiboot booting stage.
>
> Cc: stable # 5.3.0+
> Reported-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> Tested-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>

Thanks, merged to
master as of 1408f6f
and skiboot-5.3.x as of 9770dbf

-- 
Stewart Smith
OPAL Architect, IBM.