[Skiboot] [PATCH 4/5] external/pflash: Catch incompatible combination of flags

[Cyril Bur]

On Fri, 2016-10-21 at 19:55 +1030, Joel Stanley wrote:
> On Fri, Oct 21, 2016 at 7:22 PM, Cyril Bur <cyril.bur at au1.ibm.com>
> wrote:
> > Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> > ---
> >  external/pflash/pflash.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/external/pflash/pflash.c b/external/pflash/pflash.c
> > index 002d0dc..608220f 100644
> > --- a/external/pflash/pflash.c
> > +++ b/external/pflash/pflash.c
> > @@ -743,6 +743,16 @@ int main(int argc, char *argv[])
> >                 exit(1);
> >         }
> > 
> > +       if (flashfilename && bmc_flash) {
> > +               fprintf(stderr, "Filename or bmc flash but not
> > both\n");
> > +               exit(1);
> > +       }
> > +
> > +       if (flashfilename && mtd) {
> > +               fprintf(stderr, "Filename or mtd access but not
> > both\n");
> 
> How do I specify a given mtd path?

Either do nothing and pflash will find it for you. 'Should just work'
for both AMI and OpenBMC systems and of course the host. Or use '-F, --
flash-filename' and specify /dev/mtdx which should be a full PNOR,
/dev/mtd7 on OpenBMC systems

Cyril


>