[Skiboot] [PATCH] core/pel: Validate 'system-id' DT property before using

[Stewart Smith]

Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> On 10/11/2016 10:23 AM, Stewart Smith wrote:
>> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>>> Platforms like mambo doesn't populate 'system-id' DT property. Validate
>>> these properties before using.
>>>
>>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>>> ---
>>>   core/pel.c |   14 ++++++++++----
>>>   1 file changed, 10 insertions(+), 4 deletions(-)
>>
>> I fixed 'make check' (specifically core/test/run-pel.c unit test) and
>
> Thanks!
>
> May be I should change make -> make check in my build environment so that I stop 
> breaking test cases.

What I do is "make -j20 all check" just so that I catch any skiboot.lid
compile errors first before it goes off running the tests.

Also valuable is having mambo and qemu (with powernv) built and laying
around.

My typical build+test command is:
QEMU_PATH=~/qemu/ppc64-softmmu/ MAMBO_PATH=/home/stewart/mambo/bin/ \
MAMBO_BINARY=systemsim-pegasus LIB_DIR=/home/stewart/mambo/lib \
make -j20 all check

(plus the appropriate CROSS= for whatever toolchain I'm using this week)

-- 
Stewart Smith
OPAL Architect, IBM.