[Skiboot] [PATCH v3] flash: Move flash node under ibm, opal/flash/

Michael Neuling mikey at neuling.org
Thu Oct 20 11:03:14 AEDT 2016


On Wed, 2016-10-19 at 20:22 +1100, Stewart Smith wrote:
> Michael Neuling <mikey at neuling.org> writes:
> > 
> > On Wed, 2016-08-10 at 19:20 -0500, Jack Miller wrote:
> > > 
> > > This changes the boot ABI, so it's only active for P9 and later systems,
> > > even though it's unrelated to hardware changes. There is an associated
> > > Linux change to properly search for this node as well.
> > We can't have backwards incompatible device tree changes!
> > 
> > We need to revert this.  This breaks existing Linux kernels.
> > 
> > Stewart, please revert e1e6d009860d0ef60f9daf7a0fbe15f869516bd0
> > 
> > I just spend an afternoon working out why my flash disappeared when I
> > upgraded
> > skiboot.
> So it seems that the ship has sailed for such things for p9 timeframe,
> and instead we'll have to go and add a workaround in FWTS (at least for
> this).

Even if it hadn't sailed, in future we are trying to keep kernel backwards
compatibility over new CPU releases.  In that world, we can't make this type of
backwards incompatible change.

> Anyway, reverted for now.

Thanks.

Mikey


More information about the Skiboot mailing list