[Skiboot] [PATCH 0/2] Full remaining TB in skiboot log

Balbir Singh bsingharora at gmail.com
Mon Oct 17 13:32:49 AEDT 2016



On 17/10/16 11:55, Stewart Smith wrote:
> Balbir Singh <bsingharora at gmail.com> writes:
>> On 12/10/16 16:26, Stewart Smith wrote:
>>> Not 100% sure if this is the way I want to go, so posting for comments.
>>>
>>> Currently skiboot log is [SECONDS.X/512000000ths, LOG LEVEL], so it's not
>>> a decimal after the decimal point as one may expect.
>>>
>>> Also, since this is 9 characters rather than 6, a log entry of 6.110 comes
>>> *AFTER* 6.20, which is decidedly non-obvious.
>>>
>>
>> Hmm.. How do we sort our log entry, isn't it just plain FIFO?
> 
> It is. Just that leading 0s weren't being printed, so it was looking wrong.
> 

Good catch! FYI: The linux kernel also does

        return sprintf(buf, "[%5lu.%06lu] ",
                       (unsigned long)ts, rem_nsec / 1000);


in print_time()

Balbir Singh


More information about the Skiboot mailing list