[Skiboot] [PATCH] Declare proc_chip_quirks as extern, squash sparse warning

Stewart Smith stewart at linux.vnet.ibm.com
Wed Oct 12 13:31:04 AEDT 2016


include/chip.h:134:3: warning: symbol 'proc_chip_quirks' was not declared. Should it be static?

In fact it shouldn't be static, it should just exist *once* and that
place is chip.c

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 include/chip.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/chip.h b/include/chip.h
index 396e41f22df9..61b413ce97ba 100644
--- a/include/chip.h
+++ b/include/chip.h
@@ -131,7 +131,9 @@ enum proc_chip_quirks {
 	QUIRK_SIMICS		= 0x00000020,
 	QUIRK_SLOW_SIM		= 0x00000040,
 	QUIRK_NO_DIRECT_CTL	= 0x00000080,
-} proc_chip_quirks;
+};
+
+extern enum proc_chip_quirks proc_chip_quirks;
 
 static inline bool chip_quirk(unsigned int q)
 {
-- 
2.1.4



More information about the Skiboot mailing list