[Skiboot] [PATCH] pflash: Fix compilation warning

Stewart Smith stewart at linux.vnet.ibm.com
Tue Oct 11 16:00:59 AEDT 2016


Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> pflash.c: In function 'main':
> pflash.c:781:8: warning: passing argument 3 of 'blocklevel_get_info' from incompatible pointer type
> ./libflash/blocklevel.h:64:5: note: expected 'uint64_t *' but argument is of type 'uint32_t *'
>
> Fixes : c043065c (flash: Make size 64 bit safe)
> CC: Michael Neuling <mikey at neuling.org>
> CC: Cyril Bur <cyrilbur at gmail.com>
>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>  external/pflash/pflash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

for the record, there's 7bf89d68b8dd3b12d4540e9901f9d5ed325cf94d which
fixed this by using uint64_t instead, which fixed an addresssanitizer
warning (buffer overflow).

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list