[Skiboot] [PATCH 04/40] libc/string: add memcpy_from_ci()

[Stewart Smith]

Balbir Singh <bsingharora at gmail.com> writes:
> On 10/10/16 19:43, Stewart Smith wrote:
>> From: Claudio Carvalho <cclaudio at linux.vnet.ibm.com>
>> 
>> This adds memcpy_from_ci, a cache inhibited version of memcpy, required
>> by secure boot. The secure boot verification code is stored in a secure
>> ROM and the logic that contains the ROM within the processor is
>> implemented in a way that it only responds to CI (cache inhibited)
>> operations. Due to performance issues we copy the verification code from
>> the secure ROM to RAM and we use memcpy_ci for that.
>> 
>> What makes memcpy_ci vs ordinary memcpy?
>> 
>
> I think the changelog is not properly all converted over, it still has
> references to memcpy_ci as opposed to memcpy_from_ci.

Doh, I missed that too.

>> +	/*
>> +	 * Byte-by-byte copy if srcp is not block aligned or len is/becomes
>> +	 * less than one block
>> +	 */
>
> Can we have a pr_log(PR_devel,..) for unaligned copies to warn users?

I guess there isn't an issue calling in from libc... want to send a
patch? :)

-- 
Stewart Smith
OPAL Architect, IBM.