[Skiboot] [PATCH 03/11] hdat: Add new fields to IPL params structure

Oliver O'Halloran oohall at gmail.com
Mon Oct 10 19:36:56 AEDT 2016


On Mon, Oct 10, 2016 at 5:43 PM, Vasant Hegde
<hegdevasant at linux.vnet.ibm.com> wrote:
> On 09/28/2016 05:35 PM, Vasant Hegde wrote:
>>
>> Add new fields to sys params structure and update sys family for p9.
>>
>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>> ---
>>   hdata/spira.c |  3 +++
>>   hdata/spira.h | 17 ++++++++++++++++-
>>   2 files changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/hdata/spira.c b/hdata/spira.c
>> index 59ffc1d..61fb68a 100644
>> --- a/hdata/spira.c
>> +++ b/hdata/spira.c
>> @@ -788,6 +788,9 @@ static void add_iplparams_sys_params(const void *iplp,
>> struct dt_node *node)
>>         case 3:
>>                 sys_family = "ibm,firenze";
>>                 break;
>> +       case 4:
>> +               sys_family = "ibm,p9";
>
>
> I think family field is common for all P9 systems. May be we should use
> 'System Type' here and define machine definition based on that.

The current convention seems to be that the "family" is set by the
service processor type since it's different for each generation of
FSP. The current specs suggests that ibm,p9 should be the family type
for the P9 FSP machines with BMC machines being something else
entirely.

I've got a patch to set these from the family and type fields they
added to the IPL params, I'll post it as a reply.

Oliver


More information about the Skiboot mailing list