[Skiboot] [PATCH V7 00/12] ELOG generalization

[Mukesh Ojha]

Hi Stewart,

Did you get a chance to look into this patch series?

-Mukesh

On Wednesday 07 September 2016 03:51 PM, Mukesh Ojha wrote:
> Currently, in the process of committing an error from OPAL to FSP, log
> info is first internally converted to PEL format. Then all the errors
> reported by OPAL are logged to FSP. So, all the errors logs
> (FSP logs + OPAL logs) FSP sends back to host via OPAL. If for some reason
> (say FSP is down) OPAL is not able to log its error to FSP within a
> particular time, then it sends the log to the host directly.
>
> This patchset improves current error log infrastructure by splitting
> existing FSP specific error log read/write routines into common and
> hardware(FSP) specific routines. This would make the way easier in
> enabling the error log writing to host support for BMC and other
> platforms.
>
> It involves movement of some functions from FSP specific fsp-elog-write.c
> and fsp-elog-read.c files to core/errorlog.c . Introduction of platform
> hooks for elog info, ack, read and resend pending logs.
>
> This patchset removes redundant code like 'elog_enabled' check and
> 'elog_reject_head()' routine in some of the places which will elaborated
> in the individual patch.
>
> It replaces elog_init() usage with opal_elog_init().
>
> Mukesh Ojha (12):
>    errorlog : Modification as per coding guidelines to make the code more
>      legible
>    errorlog: Remove the elog enable check from
>      'fsp_elog_check_and_fetch_head'
>    errorlog: Removal of elog_reject_head() from 'opal_kexec_elog_notify'
>      routine
>    errorlog: Generalize the error log write path to host
>    errorlog: Give function 'fsp_elog_write_set_head_state' a more
>      meaningful name
>    errorlog: Generalize the error log read path
>    errorlog: Rename 'fsp_log_state' to 'sp_log_state'
>    errorlog: Introduce get and put elog routine and reference count field
>      in elog structure
>    errorlog: Replace elog_init() with opal_elog_init() for QEMU platform
>    errorlog: Remove the usage of 'elog_init()' routine, replaces it with
>      'opal_elog_init()' for BMC systems
>    errorlog: Enable error log write to host on BMC systems
>    errorlog: Add generic elog write interface
>
>   core/errorlog.c             | 313 +++++++++++++++++++++++++++++++++++++++++---
>   core/init.c                 |   4 +
>   hw/fsp/fsp-elog-read.c      | 238 ++++++++++++---------------------
>   hw/fsp/fsp-elog-write.c     | 260 +++++++-----------------------------
>   hw/ipmi/ipmi-sel.c          |  90 ++++++++-----
>   include/errorlog.h          |  22 +++-
>   include/fsp-elog.h          |  37 ++----
>   include/platform.h          |  25 +++-
>   platforms/astbmc/common.c   |   3 +-
>   platforms/ibm-fsp/apollo.c  |   7 +-
>   platforms/ibm-fsp/common.c  |   1 +
>   platforms/ibm-fsp/firenze.c |   7 +-
>   platforms/qemu/qemu.c       |   2 -
>   13 files changed, 551 insertions(+), 458 deletions(-)
>