[Skiboot] [PATCH V2] Add fwts annotation for duplicate DT node entries.

[Pridhiviraj Paidipeddi]

Reference bug: https://github.com/open-power/op-build/issues/751

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
---

Changes from v2:
	- Replaced same node ID with duplicate node
	- Generalized fwts annotation description

 core/device.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/core/device.c b/core/device.c
index 63b5df8..8897477 100644
--- a/core/device.c
+++ b/core/device.c
@@ -116,7 +116,17 @@ bool dt_attach_root(struct dt_node *parent, struct dt_node *root)
 
 		/* Look for duplicates */
 		if (cmp == 0) {
-			prerror("DT: %s failed, duplicate %s\n",
+	                /**
+                         * @fwts-label DTHasDuplicateNodeID
+                         * @fwts-advice OPAL can parse the Flatten Device Tree(FDT), which is generated
+                         *     by different firmware sources. During expansion of FDT, OPAL observed
+                         *     the duplicate node assigned multiple times. This means platform XML can
+                         *     contain either duplicate node ID for same hardware device or for different
+                         *     hardware devices. This is a bug in firmware component of platform xml,
+                         *     due to which firmware/OPAL won't add the hardware device found with a
+                         *     duplicate node ID into DT. And corresponding device is not functional.
+                         */
+			prlog(PR_ERR, "DT: %s failed, duplicate %s\n",
 				__func__, root->name);
 			return false;
 		}
-- 
2.7.4