[Skiboot] [PATCH] Add fwts annotation for duplicate DT node entries.

[Vasant Hegde]

On 11/17/2016 11:08 AM, ppaidipe at linux.vnet.ibm.com wrote:
> From: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
>
> Reference bug: https://github.com/open-power/op-build/issues/751
>
> Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
> ---
>   core/device.c | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/core/device.c b/core/device.c
> index 63b5df8..cf19f9b 100644
> --- a/core/device.c
> +++ b/core/device.c
> @@ -116,7 +116,17 @@ bool dt_attach_root(struct dt_node *parent, struct dt_node *root)
>
>   		/* Look for duplicates */
>   		if (cmp == 0) {
> -			prerror("DT: %s failed, duplicate %s\n",
> +	                /**
> +                         * @fwts-label DTHasDuplicateNodeID
> +                         * @fwts-advice OPAL Expands the Flatten Device Tree(FDT) generated
> +                         *     by hostboot. During Expansion of FDT, OPAL observed the same node id

better s/same node id/duplicate node/?

Also this description is too specific to hostboot.. But OPAL can parse fdt from 
any source and we can hit similar issue. May be you should generalize this 
little bit.

-Vasant

> +                         *     assigned multiple times. This means platform xml can contain either
> +                         *     duplicate node ID for same hardware device or for different hardware
> +                         *     devices. This is a bug in firmware component of platform xml, due to
> +                         *     which firmware/OPAL won't add the hardware device found with a duplicate
> +                         *     node ID into DT. And corresponding device is not functional.
> +                         */
> +			prlog(PR_ERR, "DT: %s failed, duplicate %s\n",
>   				__func__, root->name);
>   			return false;
>   		}
>